Launchpad itself

Merge ~cjwatson/launchpad:build-tarball-yarn into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. build-tarball-yarn
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 785c4abc441dee2731d965c2683a962528791167
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:build-tarball-yarn
Merge into: launchpad:master
Diff against target: 12 lines (+1/-0)
1 file modified
utilities/build-tarball (+1/-0)
Reviewer Review Type Date Requested Status
Guruprasad Approve
Review via email: mp+442018@code.launchpad.net

Commit message

Include download-cache/yarn/ in deployment tarballs

Description of the change

This adds about 25 MiB to the size of those tarballs, but it makes it possible for us to run `make build` in a charmed deployment, which is needed for deploying our frontend assets using Juju.

To post a comment you must log in.
Revision history for this message
Guruprasad (lgp171188) wrote :

LGTM 👍🏼

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/utilities/build-tarball b/utilities/build-tarball
2index 22cba4a..afacd81 100755
3--- a/utilities/build-tarball
4+++ b/utilities/build-tarball
5@@ -30,6 +30,7 @@ mkdir -p "$output_dir"
6 # Most of download-cache is unnecessary since we include a wheelhouse
7 # instead, but JavaScript-enabled builds need yarn.
8 find ./download-cache/dist/ -name yarn-\*.tar.gz
9+ find ./download-cache/yarn/ -type f
10 echo ./version-info.py
11 echo ./version-info.txt
12 find ./wheels/ -name \*.whl -print

Subscribers

People subscribed via source and target branches

to status/vote changes: