Merge ~cjwatson/launchpad:charm-charmhub-secrets-private-key into launchpad:master

Proposed by Colin Watson
Status: Rejected
Rejected by: Colin Watson
Proposed branch: ~cjwatson/launchpad:charm-charmhub-secrets-private-key
Merge into: launchpad:master
Diff against target: 29 lines (+8/-0)
2 files modified
charm/launchpad-appserver/config.yaml (+5/-0)
charm/launchpad-appserver/templates/launchpad-appserver-secrets-lazr.conf (+3/-0)
Reviewer Review Type Date Requested Status
Colin Watson (community) Disapprove
Review via email: mp+441598@code.launchpad.net

Commit message

charm: Add charmhub_secrets_private_key

Description of the change

Otherwise Charmhub authorization doesn't work when authorizing upload of charm recipe builds.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Wait, no, this is wrong - the appserver just needs to be able to _encrypt_, not decrypt. Withdrawing this.

review: Disapprove

Unmerged commits

1c14aad... by Colin Watson

charm: Add charmhub_secrets_private_key

Otherwise Charmhub authorization doesn't work when authorizing upload of
charm recipe builds.

Succeeded
[SUCCEEDED] docs:0 (build)
[SUCCEEDED] lint:0 (build)
[SUCCEEDED] mypy:0 (build)
13 of 3 results

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/launchpad-appserver/config.yaml b/charm/launchpad-appserver/config.yaml
2index f016031..117b9eb 100644
3--- a/charm/launchpad-appserver/config.yaml
4+++ b/charm/launchpad-appserver/config.yaml
5@@ -8,6 +8,11 @@ options:
6 description: >
7 Cognitive Services subscription key for the Bing Custom Search API.
8 default:
9+ charmhub_secrets_private_key:
10+ type: string
11+ description: >
12+ Base64-encoded NaCl private key for decrypting Charmhub upload tokens.
13+ default:
14 csrf_secret:
15 type: string
16 description: >
17diff --git a/charm/launchpad-appserver/templates/launchpad-appserver-secrets-lazr.conf b/charm/launchpad-appserver/templates/launchpad-appserver-secrets-lazr.conf
18index 10da8a6..0d47a5c 100644
19--- a/charm/launchpad-appserver/templates/launchpad-appserver-secrets-lazr.conf
20+++ b/charm/launchpad-appserver/templates/launchpad-appserver-secrets-lazr.conf
21@@ -13,6 +13,9 @@
22 [bing]
23 {{- opt("subscription_key", bing_subscription_key) }}
24
25+[charms]
26+{{- opt("charmhub_secrets_private_key", charmhub_secrets_private_key) }}
27+
28 [codehosting]
29 {{- opt("git_macaroon_secret_key", git_macaroon_secret_key) }}
30

Subscribers

People subscribed via source and target branches

to status/vote changes: