Merge ~cjwatson/launchpad:charm-admin-apply-security into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | b1500e83e54dab6584ca3b4b4b0d0f8efb9a06dc |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:charm-admin-apply-security |
Merge into: | launchpad:master |
Diff against target: |
113 lines (+53/-4) 4 files modified
charm/launchpad-admin/reactive/launchpad-admin.py (+50/-1) charm/launchpad-admin/templates/db-admin.j2 (+1/-1) charm/launchpad-admin/templates/db-session.j2 (+1/-1) charm/launchpad-admin/templates/db.j2 (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guruprasad | Approve | ||
Review via email: mp+440257@code.launchpad.net |
Commit message
charm: Update DB permissions when configuring launchpad-admin
Description of the change
This replaces code currently run by our deployment machinery at the end of its `build` phase.
I also fixed a typo in a reactive flag name that caused hooks to do unnecessary work, since we were never considering the service to be configured.
To post a comment you must log in.
LGTM ๐๐ผ