Merge ~cjwatson/launchpad:better-oops-traceback-annotations into launchpad:master
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | d00b1f5c789e5fa4a19c2c4b13cbcf00d4ac6c04 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:better-oops-traceback-annotations |
Merge into: | launchpad:master |
Diff against target: |
225 lines (+94/-37) 3 files modified
lib/lp/services/timeline/requesttimeline.py (+57/-3) lib/lp/services/webapp/adapter.py (+8/-34) lib/lp/services/webapp/tests/test_statementtracer.py (+29/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jürgen Gmach | Approve | ||
Review via email: mp+438607@code.launchpad.net |
Commit message
Include traceback supplements and info in timelines
Description of the change
Some code adds extra information to tracebacks (documented in https:/
Adjust the way we construct `Timeline` objects so that they format tracebacks using the machinery in `zope.exceptions`, which knows how to deal with this extra information.
Thanks! That will be a big help!