Merge ~cjwatson/launchpad:git-delete-expired-access-tokens into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | f26c2e6b2eba79c17fa28bf738aa44993b375c1f |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:git-delete-expired-access-tokens |
Merge into: | launchpad:master |
Diff against target: |
173 lines (+65/-12) 5 files modified
lib/lp/code/model/gitrepository.py (+3/-1) lib/lp/code/model/tests/test_gitrepository.py (+10/-0) lib/lp/services/auth/interfaces.py (+13/-3) lib/lp/services/auth/model.py (+13/-8) lib/lp/services/auth/tests/test_model.py (+26/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guruprasad | Approve | ||
Review via email: mp+436489@code.launchpad.net |
Commit message
Delete expired access tokens when deleting a Git repository
Description of the change
Attempting to delete a repository with an expired access token failed with:
update or delete on table "gitrepository" violates foreign key constraint "accesstoken_
Delete expired access tokens as well as valid ones.
To post a comment you must log in.
LGTM 👍