Launchpad itself

Merge ~cjwatson/launchpad:branch-subscription-security into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. branch-subscription-security
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 1de005e14e6d157fd85d02d70cacc9a3f70f1b42
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:branch-subscription-security
Merge into: launchpad:master
Diff against target: 21 lines (+2/-2)
1 file modified
lib/lp/code/configure.zcml (+2/-2)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+436198@code.launchpad.net

Commit message

Fix security declarations for I{Branch,Git}Subscription

Description of the change

I'm not sure whether these were actually a problem in practice since the corresponding UI views had appropriate permissions, but defence in depth is normally a good idea.

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/code/configure.zcml b/lib/lp/code/configure.zcml
2index 035facb..b962de7 100644
3--- a/lib/lp/code/configure.zcml
4+++ b/lib/lp/code/configure.zcml
5@@ -351,7 +351,7 @@
6 <allow interface="lp.code.interfaces.branchsubscription.IBranchSubscription"/>
7 <allow interface="lp.code.interfaces.branchtarget.IHasBranchTarget"/>
8 <require
9- permission="zope.Public"
10+ permission="launchpad.Edit"
11 set_schema="lp.code.interfaces.branchsubscription.IBranchSubscription"/>
12 </class>
13
14@@ -893,7 +893,7 @@
15 <class class="lp.code.model.gitsubscription.GitSubscription">
16 <allow interface="lp.code.interfaces.gitsubscription.IGitSubscription"/>
17 <require
18- permission="zope.Public"
19+ permission="launchpad.Edit"
20 set_schema="lp.code.interfaces.gitsubscription.IGitSubscription"/>
21 </class>
22

Subscribers

People subscribed via source and target branches

to status/vote changes: