Merge ~cjwatson/launchpad:bump-librarian-timeout into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: d116336de72d65af5121d1e492177fab2e9d0020
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:bump-librarian-timeout
Merge into: launchpad:master
Diff against target: 18 lines (+4/-2)
1 file modified
lib/lp/services/config/schema-lazr.conf (+4/-2)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+433714@code.launchpad.net

Commit message

Bump default librarian client socket timeout to 15 minutes

Description of the change

It turns out that what I thought was a generous timeout of a minute causes problems for some scripts that upload large files, probably because the librarian storage protocol doesn't acknowledge a block at a time after the initial header but has to store the entire file first. I didn't expect that to take more than a minute, but that's what we're seeing. Since this was only ever intended as an improvement over waiting forever, bump the timeout to 15 minutes.

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/services/config/schema-lazr.conf b/lib/lp/services/config/schema-lazr.conf
2index c2d8b4a..89ba7bd 100644
3--- a/lib/lp/services/config/schema-lazr.conf
4+++ b/lib/lp/services/config/schema-lazr.conf
5@@ -1261,9 +1261,11 @@ authentication_endpoint: none
6 # authserver.
7 authentication_timeout: 5
8
9-# The timeout in seconds for librarian client socket operations.
10+# The timeout in seconds for librarian client socket operations. Note that
11+# this is deliberately generous: it's intended as a backstop to ensure that
12+# scripts don't get stuck waiting forever in the event of network outages.
13 # datatype: integer
14-client_socket_timeout: 60
15+client_socket_timeout: 900
16
17
18 [librarian_gc]

Subscribers

People subscribed via source and target branches

to status/vote changes: