Merge ~cjwatson/launchpad:sitesearch-testservice-cleanup into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | c85cf87e4ba3ba0c6d50e97fe500a3f11583481f |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:sitesearch-testservice-cleanup |
Merge into: | launchpad:master |
Diff against target: |
16 lines (+2/-3) 1 file modified
lib/lp/services/sitesearch/testservice.py (+2/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrey Fedoseev (community) | Approve | ||
Review via email: mp+433673@code.launchpad.net |
Commit message
Connect stdin/stdout of site search test service to /dev/null
Description of the change
Setting these up as pipes without having anything ever communicate with it, as we previously did, had two disadvantages: it could cause the test service to block if it tries to write too much to stdout, and it caused a `ResourceWarning` due to `proc.stdout` never being explicitly closed.
To post a comment you must log in.