Merge ~cjwatson/launchpad:remove-deprecated-config into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 112a41786a0e9c06173c5ace41350931b4c5e10b
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:remove-deprecated-config
Merge into: launchpad:master
Diff against target: 102 lines (+0/-46)
2 files modified
configs/development/launchpad-lazr.conf (+0/-7)
lib/lp/services/config/schema-lazr.conf (+0/-39)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+431862@code.launchpad.net

Commit message

Remove a number of deprecated configuration items

Description of the change

Most of these were removed from Launchpad as part of splitting out `lp-codeimport`; `launchpad.use_gunicorn` was removed entirely.

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/configs/development/launchpad-lazr.conf b/configs/development/launchpad-lazr.conf
2index c8ca016..97e07c4 100644
3--- a/configs/development/launchpad-lazr.conf
4+++ b/configs/development/launchpad-lazr.conf
5@@ -55,13 +55,6 @@ git_ssh_root: git+ssh://git.launchpad.test/
6 loose_objects_threshold: 4350
7 packs_threshold: 30
8
9-[codeimport]
10-bazaar_branch_store: file:///tmp/bazaar-branches
11-foreign_tree_store: file:///tmp/foreign-branches
12-
13-[codeimportdispatcher]
14-forced_hostname: bazaar-importer
15-
16 [database]
17 rw_main_primary: dbname=launchpad_dev
18 rw_main_standby: dbname=launchpad_dev
19diff --git a/lib/lp/services/config/schema-lazr.conf b/lib/lp/services/config/schema-lazr.conf
20index a30ee93..cf9c276 100644
21--- a/lib/lp/services/config/schema-lazr.conf
22+++ b/lib/lp/services/config/schema-lazr.conf
23@@ -473,10 +473,6 @@ auto_repack_frequency: 10080
24
25
26 [codeimport]
27-# Where the Bazaar imports are stored.
28-# datatype: string
29-bazaar_branch_store: sftp://hoover@escudero/srv/importd/www/
30-
31 # The default value of the update interval of a code import from
32 # Subversion, in seconds.
33 # datatype: integer
34@@ -497,10 +493,6 @@ default_interval_cvs: 43200
35 # datatype: integer
36 default_interval_bzr: 21600
37
38-# Where the tarballs of foreign branches are uploaded for storage.
39-# datatype: string
40-foreign_tree_store: sftp://hoover@escudero/srv/importd/sources/
41-
42 # After how many seconds to kill import workers that show no signs of
43 # activity.
44 worker_inactivity_timeout: 3600
45@@ -519,34 +511,12 @@ svn_revisions_import_limit: 500
46 # Deprecated in favour of launchpad.internal_macaroon_secret_key.
47 macaroon_secret_key: none
48
49-[codeimportdispatcher]
50-# The directory where the code import worker should be directed to
51-# store its logs.
52-worker_log_dir: /var/tmp/codeimport
53-
54-# Force the dispatcher to look for the code import machine with this
55-# hostname, rather than the hostname of the machine it is running on,
56-# so we can use a machine name from the sample data on developer
57-# machines.
58-forced_hostname: none
59-
60-# Where to find the code import scheduler service.
61-codeimportscheduler_url:
62- http://xmlrpc-private.launchpad.test:8087/codeimportscheduler
63-
64-# The maximum number of jobs to run on a machine at one time.
65-max_jobs_per_machine: 3
66-
67
68 [codeimportworker]
69 # This code is used by the code-import-worker-monitor which lives in
70 # scripts/code-import-worker-monitor.py and
71 # lib/lp/codehosting/codeimport/worker_monitor.py.
72
73-# The interval in seconds the worker should wait between updates to the
74-# heartbeat field of the CodeImportJob row representing a job.
75-heartbeat_update_interval: 30
76-
77 # The amount of time which can elapse between updating a job's heartbeat
78 # field before the job is considered reclaimable. This is somewhat
79 # arbitrarily chosen, but ten times the expected update interval should be
80@@ -554,10 +524,6 @@ heartbeat_update_interval: 30
81 # the throughput of the system when a job gets stuck for some reason.
82 maximum_heartbeat_interval: 300
83
84-# The code import worker stores its working files in a directory named
85-# worker-for-branch-${BRANCH_ID} in this directory.
86-working_directory_root: /var/tmp/codeimport/data
87-
88
89 [commercial]
90 # URL pointing to Ubuntu's licensing policy which Launchpad shares.
91@@ -939,11 +905,6 @@ max_scaling: 500
92 # Is this server running in dev mode?
93 devmode: false
94
95-# Should use gunicorn when booting, or fallback to Zope Server?
96-# XXX cjwatson 2021-07-16: Pending removal; setting this to false now has no
97-# effect.
98-use_gunicorn: true
99-
100 # A directory of files from which *-lazr.conf will be loaded and
101 # overlaid in order on top of the main config.
102 # Note that this is relative to the top-level config file, not

Subscribers

People subscribed via source and target branches

to status/vote changes: