Merge ~cjwatson/launchpad:remove-server-scopes into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 4341bdab89825ee29d29c6098f8451ca1ac1daaa |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:remove-server-scopes |
Merge into: | launchpad:master |
Diff against target: |
165 lines (+10/-58) 5 files modified
lib/lp/app/templates/base-layout.pt (+0/-1) lib/lp/services/features/__init__.py (+7/-6) lib/lp/services/features/scopes.py (+2/-23) lib/lp/services/features/tests/test_flags.py (+1/-1) lib/lp/services/features/tests/test_webapp.py (+0/-27) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jürgen Gmach | Approve | ||
Review via email: mp+431820@code.launchpad.net |
Commit message
Remove server feature scopes
Description of the change
We don't seem to use these in practice, and I can't really think of many situations where it would be more convenient to do so rather than just setting appropriate feature rules on each instance. The only somewhat relevant piece of configuration that we have right now is the `is_demo` flag, but that isn't implemented using server scopes anyway and it wouldn't be worth maintaining that code just for the sake of a single boolean.
To post a comment you must log in.