Merge ~cjwatson/launchpad:fix-dominate-sources-with-channel into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 38c2e117ab40a980961217405f7ea6b4dcdf8b8a |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:fix-dominate-sources-with-channel |
Merge into: | launchpad:master |
Diff against target: |
116 lines (+75/-5) 2 files modified
lib/lp/archivepublisher/domination.py (+5/-2) lib/lp/archivepublisher/tests/test_dominator.py (+70/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ioana Lasc (community) | Approve | ||
Review via email: mp+427776@code.launchpad.net |
Commit message
Fix domination of source publications with channels
Description of the change
We need to explicitly pass a `jsonb` operand to `IsDistinctFrom`, as otherwise it miscompiles to the nonsensical `channel IS DISTINCT FROM track IS DISTINCT FROM risk IS DISTINCT FROM branch` rather than `channel IS DISTINCT FROM CAST('[track, risk, branch]' AS jsonb)`.
To post a comment you must log in.
Good to know for future usages of `IsDistinctFrom` with json blobs.