Merge ~cjwatson/launchpad:fix-ci-build-upload-job-filter-by-repository-format into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: c3cd5ddfb0ba07cf85a6140803d71d7d32ad0c9a
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:fix-ci-build-upload-job-filter-by-repository-format
Merge into: launchpad:master
Diff against target: 30 lines (+8/-4)
1 file modified
lib/lp/soyuz/tests/test_archivejob.py (+8/-4)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+425190@code.launchpad.net

Commit message

Fix test failures due to CIBuildUploadJob limiting by format

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

This is a fairly simple buildbot fix, so self-approving.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/soyuz/tests/test_archivejob.py b/lib/lp/soyuz/tests/test_archivejob.py
2index 7047b06..51eb6f2 100644
3--- a/lib/lp/soyuz/tests/test_archivejob.py
4+++ b/lib/lp/soyuz/tests/test_archivejob.py
5@@ -603,7 +603,8 @@ class TestCIBuildUploadJob(TestCaseWithFactory):
6 def test_librarian_server_error_retries(self):
7 # A run that gets an error from the librarian server schedules
8 # itself to be retried.
9- archive = self.factory.makeArchive()
10+ archive = self.factory.makeArchive(
11+ repository_format=ArchiveRepositoryFormat.PYTHON)
12 distroseries = self.factory.makeDistroSeries(
13 distribution=archive.distribution)
14 das = self.factory.makeDistroArchSeries(distroseries=distroseries)
15@@ -664,9 +665,12 @@ class TestViaCelery(TestCaseWithFactory):
16 # CIBuildUploadJob runs under Celery.
17 self.useFixture(FeatureFixture(
18 {"jobs.celery.enabled_classes": "CIBuildUploadJob"}))
19- build = self.factory.makeCIBuild()
20- das = build.distro_arch_series
21- archive = das.distroseries.main_archive
22+ archive = self.factory.makeArchive(
23+ repository_format=ArchiveRepositoryFormat.PYTHON)
24+ distroseries = self.factory.makeDistroSeries(
25+ distribution=archive.distribution)
26+ das = self.factory.makeDistroArchSeries(distroseries=distroseries)
27+ build = self.factory.makeCIBuild(distro_arch_series=das)
28 report = build.getOrCreateRevisionStatusReport("build:0")
29 path = "wheel-indep/dist/wheel_indep-0.0.1-py3-none-any.whl"
30 with open(datadir(path), mode="rb") as f:

Subscribers

People subscribed via source and target branches

to status/vote changes: