Merge ~cjwatson/launchpad:fix-project-download-queries into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 3cec9617983f1443fc640be6296a7b08255077de
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:fix-project-download-queries
Merge into: launchpad:master
Diff against target: 26 lines (+4/-1)
2 files modified
lib/lp/services/librarian/interfaces/__init__.py (+1/-1)
lib/lp/services/librarianserver/testing/fake.py (+3/-0)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+413402@code.launchpad.net

Commit message

Fix ILibraryFileAliasSet.preloadLastDownloaded declaration

Description of the change

It had an extra `self` parameter. `FakeLibrarian` also needs a stub definition of this method.

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/services/librarian/interfaces/__init__.py b/lib/lp/services/librarian/interfaces/__init__.py
2index 73b390b..bf4055f 100644
3--- a/lib/lp/services/librarian/interfaces/__init__.py
4+++ b/lib/lp/services/librarian/interfaces/__init__.py
5@@ -175,7 +175,7 @@ class ILibraryFileAliasSet(Interface):
6 given sha256.
7 """
8
9- def preloadLastDownloaded(self, lfas):
10+ def preloadLastDownloaded(lfas):
11 """Preload last_downloaded for a collection of `LibraryFileAlias`es."""
12
13
14diff --git a/lib/lp/services/librarianserver/testing/fake.py b/lib/lp/services/librarianserver/testing/fake.py
15index ed17038..0dfc37a 100644
16--- a/lib/lp/services/librarianserver/testing/fake.py
17+++ b/lib/lp/services/librarianserver/testing/fake.py
18@@ -181,6 +181,9 @@ class FakeLibrarian(Fixture):
19
20 return None
21
22+ def preloadLastDownloaded(self, lfas):
23+ """See `ILibraryFileAliasSet`."""
24+
25 def beforeCompletion(self, txn):
26 """See `ISynchronizer`."""
27

Subscribers

People subscribed via source and target branches

to status/vote changes: