Merge ~cjwatson/launchpad:development-error-exchange into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 6f01251239eb8bd28b8c9c4184660dedbf1cc6eb
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:development-error-exchange
Merge into: launchpad:master
Diff against target: 24 lines (+2/-0)
2 files modified
configs/development/launchpad-lazr.conf (+1/-0)
configs/testrunner/launchpad-lazr.conf (+1/-0)
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+412208@code.launchpad.net

Commit message

Publish OOPSes to disk by default in development config

Description of the change

The development config previously wrote OOPSes to rabbitmq if it was running (which it normally would be within `make run`). But this is quite inconvenient for normal development purposes: unless you're also running something like python-oops-tools to receive OOPS reports over AMQP, they effectively disappear into the void and are difficult to find.

Although the test runner needs to preserve the previous behaviour, a better default for interactive use in `LPCONFIG=development` is to publish OOPSes to disk.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/configs/development/launchpad-lazr.conf b/configs/development/launchpad-lazr.conf
2index c704f29..b8ba73c 100644
3--- a/configs/development/launchpad-lazr.conf
4+++ b/configs/development/launchpad-lazr.conf
5@@ -78,6 +78,7 @@ cdimage_file_list_url: file:lib/lp/registry/tests/ubuntu-releases.testdata
6 [error_reports]
7 oops_prefix: X
8 error_dir: /var/tmp/lperr
9+error_exchange: none
10
11 [bing]
12 # Development and the testrunner should use the stub service by default.
13diff --git a/configs/testrunner/launchpad-lazr.conf b/configs/testrunner/launchpad-lazr.conf
14index 9fe2aa0..cad74b1 100644
15--- a/configs/testrunner/launchpad-lazr.conf
16+++ b/configs/testrunner/launchpad-lazr.conf
17@@ -30,6 +30,7 @@ rw_main_standby: dbname=launchpad_ftest
18 [error_reports]
19 oops_prefix: T
20 error_dir: /var/tmp/lperr.test
21+error_exchange: oopses
22
23 [gina_target.hoary]
24 architectures: i386

Subscribers

People subscribed via source and target branches

to status/vote changes: