Merge ~cjwatson/launchpad:remove-enumcol into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 0c5e3b3ea2b9fb1f224945fa95079185cc8ce618 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:remove-enumcol |
Merge into: | launchpad:master |
Diff against target: |
192 lines (+40/-50) 2 files modified
lib/lp/services/database/doc/enumcol.txt (+31/-22) lib/lp/services/database/enumcol.py (+9/-28) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ioana Lasc (community) | Approve | ||
Review via email: mp+412134@code.launchpad.net |
Commit message
Remove now-unused EnumCol
Description of the change
All call sites now use the Storm-style `DBEnum` instead.
In the process of updating tests for this, I noticed that DBEnum only checks the type of the `enum` parameter when the property is used (thus constructing the associated variable), rather than when the property is constructed; and it also failed to actually do the type check in practice due to a Python 3 porting bug. This seems inconvenient, so I moved the type check earlier and fixed it for Python 3.
To post a comment you must log in.
looks good and nice catch on the type check!