Merge ~cjwatson/launchpad:tidy-dependencies into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: cc89289db0f276168c8ad091f3e8826b7d7a5217
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:tidy-dependencies
Merge into: launchpad:master
Diff against target: 41 lines (+1/-4)
1 file modified
setup.py (+1/-4)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+411279@code.launchpad.net

Commit message

Clean up various dependencies

Description of the change

Where possible, we generally try to have direct dependencies on exactly those things that we use directly. This gets us closer to that.

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/setup.py b/setup.py
2index 5cef2f0..595f582 100644
3--- a/setup.py
4+++ b/setup.py
5@@ -147,12 +147,10 @@ setup(
6 'boto3',
7 'breezy',
8 'celery',
9- 'cssselect',
10 'cssutils',
11 'defusedxml',
12 'distro',
13 'dkimpy[ed25519]',
14- 'dulwich',
15 'feedparser',
16 'fixtures',
17 # Required for gunicorn[gthread]. We depend on it explicitly
18@@ -179,6 +177,7 @@ setup(
19 'lazr.sshserver',
20 'lazr.uri',
21 'lpjsmin',
22+ 'lxml[cssselect]',
23 'Markdown',
24 'meliae',
25 'multipart',
26@@ -197,7 +196,6 @@ setup(
27 'pyasn1',
28 'pygettextpo',
29 'pygpgme',
30- 'pyinotify',
31 'pymacaroons',
32 'pystache',
33 'python-debian',
34@@ -277,7 +275,6 @@ setup(
35 'zope.testing',
36 'zope.testrunner[subunit]',
37 'zope.traversing',
38- 'zope.viewlet', # only fixing a broken dependency
39 'zope.vocabularyregistry',
40 # Loggerhead dependencies. These should be removed once
41 # bug 383360 is fixed and we include it as a source dist.

Subscribers

People subscribed via source and target branches

to status/vote changes: