Merge ~cjwatson/launchpad:librarian-gc-ram into launchpad:master
Proposed by
Colin Watson
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Colin Watson | ||||||||
Approved revision: | 7cda2a51deb8a2ad13f0e211a24696da6ef483ed | ||||||||
Merge reported by: | Otto Co-Pilot | ||||||||
Merged at revision: | not available | ||||||||
Proposed branch: | ~cjwatson/launchpad:librarian-gc-ram | ||||||||
Merge into: | launchpad:master | ||||||||
Diff against target: |
216 lines (+51/-31) 4 files modified
cronscripts/librarian-gc.py (+12/-10) lib/lp/services/librarianserver/librariangc.py (+31/-13) lib/lp/services/librarianserver/tests/test_gc.py (+5/-5) lib/lp/testing/pgsql.py (+3/-3) |
||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ioana Lasc (community) | Approve | ||
Review via email: mp+407071@code.launchpad.net |
Commit message
librarian-gc: Use a server-side cursor for iterating LFC IDs
Description of the change
If we use a normal client-side cursor, then psycopg2 reads all the rows into memory up-front, defeating our attempt to avoid doing so.
In order to do this, I had to also fix bug 853066, because Storm's `ConnectionWrap
To post a comment you must log in.
LGTM