Merge ~cjwatson/launchpad:doctest-imported-but-unused into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 97794a7ec2531e8ea7c35c67845ad7371ad107d7
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:doctest-imported-but-unused
Merge into: launchpad:master
Diff against target: 217 lines (+3/-25)
14 files modified
lib/lp/app/browser/doc/launchpad-search-pages.txt (+0/-1)
lib/lp/archiveuploader/tests/nascentupload-packageset.txt (+0/-1)
lib/lp/archiveuploader/tests/static-translations.txt (+1/-2)
lib/lp/bugs/doc/bugtask-find-similar.txt (+0/-3)
lib/lp/bugs/doc/checkwatches-batching.txt (+0/-1)
lib/lp/bugs/stories/bugtask-searches/xx-searching-by-tags.txt (+0/-1)
lib/lp/code/stories/codeimport/xx-admin-codeimport.txt (+1/-1)
lib/lp/registry/doc/personlocation.txt (+0/-1)
lib/lp/registry/doc/poll-preconditions.txt (+0/-2)
lib/lp/registry/stories/gpg-coc/xx-gpg-coc.txt (+1/-3)
lib/lp/services/database/doc/textsearching.txt (+0/-3)
lib/lp/services/scripts/doc/launchpad-scripts.txt (+0/-4)
lib/lp/services/webservice/doc/webservice-error.txt (+0/-1)
lib/lp/translations/stories/standalone/xx-pofile-translate-dismiss-suggestions.txt (+0/-1)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+406175@code.launchpad.net

Commit message

Remove unused imports from doctests

Description of the change

Found by lp-lint-doctest.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Self-approving (trivial).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/app/browser/doc/launchpad-search-pages.txt b/lib/lp/app/browser/doc/launchpad-search-pages.txt
2index abc6e37..5578b26 100644
3--- a/lib/lp/app/browser/doc/launchpad-search-pages.txt
4+++ b/lib/lp/app/browser/doc/launchpad-search-pages.txt
5@@ -5,7 +5,6 @@ Users can search for Launchpad objects and pages from the search form
6 located on all pages. The search is performed and displayed by the
7 LaunchpadSearchView.
8
9- >>> import six
10 >>> from zope.component import getMultiAdapter, getUtility
11 >>> from lp.services.webapp.interfaces import ILaunchpadRoot
12 >>> from lp.services.webapp.servers import LaunchpadTestRequest
13diff --git a/lib/lp/archiveuploader/tests/nascentupload-packageset.txt b/lib/lp/archiveuploader/tests/nascentupload-packageset.txt
14index 6ad0c8f..3397177 100644
15--- a/lib/lp/archiveuploader/tests/nascentupload-packageset.txt
16+++ b/lib/lp/archiveuploader/tests/nascentupload-packageset.txt
17@@ -48,7 +48,6 @@ This time the upload will fail because the ACLs don't let
18 We can grant selective, package set based upload permissions to the user
19 in order to facilitate uploads.
20
21- >>> import operator
22 >>> def print_permission(result_set):
23 ... for perm in result_set.order_by(
24 ... 'person, permission, packageset, explicit'):
25diff --git a/lib/lp/archiveuploader/tests/static-translations.txt b/lib/lp/archiveuploader/tests/static-translations.txt
26index 52b7a25..f6b7baa 100644
27--- a/lib/lp/archiveuploader/tests/static-translations.txt
28+++ b/lib/lp/archiveuploader/tests/static-translations.txt
29@@ -25,8 +25,7 @@ publishing behaviour using a mock PackageUploadCustom object:
30 >>> from lp.registry.interfaces.distribution import IDistributionSet
31 >>> from lp.registry.interfaces.pocket import PackagePublishingPocket
32 >>> from lp.soyuz.enums import PackageUploadCustomFormat
33- >>> from lp.soyuz.interfaces.queue import (
34- ... IPackageUpload, IPackageUploadCustom)
35+ >>> from lp.soyuz.interfaces.queue import IPackageUploadCustom
36 >>> from lp.soyuz.model.queue import PackageUploadCustom
37 >>> @implementer(IPackageUploadCustom)
38 ... class MockPackageUploadCustom(PackageUploadCustom):
39diff --git a/lib/lp/bugs/doc/bugtask-find-similar.txt b/lib/lp/bugs/doc/bugtask-find-similar.txt
40index b3396ee..204199c 100644
41--- a/lib/lp/bugs/doc/bugtask-find-similar.txt
42+++ b/lib/lp/bugs/doc/bugtask-find-similar.txt
43@@ -13,8 +13,6 @@ It doesn't make much sense to find bugs similar to an empty string, so
44 no results will be returned.
45
46 >>> from lp.bugs.interfaces.bugtask import IBugTaskSet
47- >>> from lp.registry.interfaces.person import IPersonSet
48- >>> from lp.registry.interfaces.product import IProductSet
49 >>> test_product = factory.makeProduct()
50 >>> test_person = factory.makePerson()
51 >>> similar_bugs = getUtility(IBugTaskSet).findSimilar(
52@@ -101,7 +99,6 @@ Only bugs that the user has access to view will be searched. If we set
53 one of our distro bugs to private, and repeat the search as a user who
54 isn't allowed to view it, only the public bugs will show up.
55
56- >>> from lp.bugs.interfaces.bug import IBugSet
57 >>> login('test@canonical.com')
58 >>> distro_bug_1.setPrivate(True, distro_bug_1.owner)
59 True
60diff --git a/lib/lp/bugs/doc/checkwatches-batching.txt b/lib/lp/bugs/doc/checkwatches-batching.txt
61index 16b165b..5700e17 100644
62--- a/lib/lp/bugs/doc/checkwatches-batching.txt
63+++ b/lib/lp/bugs/doc/checkwatches-batching.txt
64@@ -7,7 +7,6 @@ for batching up operations.
65
66 >>> import transaction
67 >>> from lp.bugs.scripts.checkwatches import CheckwatchesMaster
68- >>> from pprint import pprint
69
70 >>> updater = CheckwatchesMaster(transaction)
71 >>> transaction.commit()
72diff --git a/lib/lp/bugs/stories/bugtask-searches/xx-searching-by-tags.txt b/lib/lp/bugs/stories/bugtask-searches/xx-searching-by-tags.txt
73index e279296..e99a644 100644
74--- a/lib/lp/bugs/stories/bugtask-searches/xx-searching-by-tags.txt
75+++ b/lib/lp/bugs/stories/bugtask-searches/xx-searching-by-tags.txt
76@@ -42,7 +42,6 @@ Only 'test bug a' is returned.
77 ... name='field.tag').value = 'test-tag-1 test-tag-2'
78 >>> anon_browser.getControl(name='field.tags_combinator').value = ['ALL']
79 >>> anon_browser.getControl('Search', index=1).click()
80- >>> from lp.bugs.tests.bug import print_bugtasks
81 >>> 'test bug a' in anon_browser.contents
82 True
83 >>> 'test bug b' in anon_browser.contents
84diff --git a/lib/lp/code/stories/codeimport/xx-admin-codeimport.txt b/lib/lp/code/stories/codeimport/xx-admin-codeimport.txt
85index d0d49ab..3ddf93e 100644
86--- a/lib/lp/code/stories/codeimport/xx-admin-codeimport.txt
87+++ b/lib/lp/code/stories/codeimport/xx-admin-codeimport.txt
88@@ -11,7 +11,7 @@ to edit the details.
89 ... TargetRevisionControlSystems,
90 ... )
91 >>> from lp.code.tests.helpers import GitHostingFixture
92- >>> from lp.testing import ANONYMOUS, login, logout
93+ >>> from lp.testing import login, logout
94 >>> login('test@canonical.com')
95
96 >>> svn_import = factory.makeProductCodeImport(
97diff --git a/lib/lp/registry/doc/personlocation.txt b/lib/lp/registry/doc/personlocation.txt
98index 779d3d9..afe5018 100644
99--- a/lib/lp/registry/doc/personlocation.txt
100+++ b/lib/lp/registry/doc/personlocation.txt
101@@ -6,7 +6,6 @@ zone (which they can set) is stored together with their latitude/longitude (in
102 PersonLocation). Until we move the time zone back to the Person table
103 (bug=933699), we'll maintain the setLocation() API on IPerson.
104
105- >>> from lp.testing import verifyObject
106 >>> from lp.registry.interfaces.person import IPersonSet
107 >>> personset = getUtility(IPersonSet)
108
109diff --git a/lib/lp/registry/doc/poll-preconditions.txt b/lib/lp/registry/doc/poll-preconditions.txt
110index f1fcc1c..b6d5dba 100644
111--- a/lib/lp/registry/doc/poll-preconditions.txt
112+++ b/lib/lp/registry/doc/poll-preconditions.txt
113@@ -6,8 +6,6 @@ options from them, Not meeting these preconditions is a programming error and
114 should be threated as so.
115
116 >>> from zope.component import getUtility
117- >>> from lp.services.database.sqlbase import flush_database_updates
118- >>> from lp.testing import login
119 >>> from datetime import timedelta
120 >>> from lp.registry.interfaces.person import IPersonSet
121 >>> from lp.registry.interfaces.poll import IPollSet
122diff --git a/lib/lp/registry/stories/gpg-coc/xx-gpg-coc.txt b/lib/lp/registry/stories/gpg-coc/xx-gpg-coc.txt
123index 206cfcf..1cc088e 100644
124--- a/lib/lp/registry/stories/gpg-coc/xx-gpg-coc.txt
125+++ b/lib/lp/registry/stories/gpg-coc/xx-gpg-coc.txt
126@@ -502,7 +502,7 @@ Now they'll request their key to be reactivated.
127
128 Get the token from the body of the email sent.
129
130- >>> import email, re
131+ >>> import re
132 >>> from lp.services.mail import stub
133 >>> from_addr, to_addrs, raw_msg = stub.test_emails.pop()
134 >>> msg = message_from_bytes(raw_msg)
135@@ -549,7 +549,6 @@ And now we can see the key listed as one of Sample Person's active keys.
136 This test verifies that we correctly handle keys which are in some way
137 special: either invalid, broken, revoked, expired, or already imported.
138
139- >>> import email
140 >>> from lp.testing.keyserver import KeyServerTac
141 >>> from lp.services.mail import stub
142
143@@ -620,7 +619,6 @@ Ensure the CoC was acknowledge by searching in the CoC Admin Console:
144
145 Test if the advertisement email was sent:
146
147- >>> import email
148 >>> from lp.services.mail import stub
149 >>> from_addr, to_addrs, raw_msg = stub.test_emails.pop()
150 >>> msg = message_from_bytes(raw_msg)
151diff --git a/lib/lp/services/database/doc/textsearching.txt b/lib/lp/services/database/doc/textsearching.txt
152index 65d8f9d..63e5d5a 100644
153--- a/lib/lp/services/database/doc/textsearching.txt
154+++ b/lib/lp/services/database/doc/textsearching.txt
155@@ -96,7 +96,6 @@ any syntax error exceptions being generated.
156 The following examples show the text version of the query using
157 `_ftq(text)`, and the compiled version returned by `ftq(text)`
158
159- >>> from lp.services.database.sqlbase import SQLBase
160 >>> def ftq(query):
161 ... try:
162 ... result = store.execute(
163@@ -691,7 +690,6 @@ that is matched by each term. Term matching 50% or more of the total
164 rows will be excluded from the final search.
165
166 >>> from lp.services.database.nl_search import nl_phrase_search
167- >>> from lp.services.database.sqlbase import quote
168 >>> from lp.answers.model.question import Question
169
170 More than 50% of the questions matches firefox:
171@@ -783,7 +781,6 @@ keywords could be eliminated. For that reason, when there are less than
172 For example, there are less than 5 questions filed on the
173 mozilla-firefox source package.
174
175- >>> from lp.services.database.sqlbase import sqlvalues
176 >>> from lp.registry.interfaces.distribution import IDistributionSet
177 >>> ubuntu = getUtility(IDistributionSet).getByName('ubuntu')
178 >>> firefox_package = ubuntu.getSourcePackage('mozilla-firefox')
179diff --git a/lib/lp/services/scripts/doc/launchpad-scripts.txt b/lib/lp/services/scripts/doc/launchpad-scripts.txt
180index 7eea651..9a51be6 100644
181--- a/lib/lp/services/scripts/doc/launchpad-scripts.txt
182+++ b/lib/lp/services/scripts/doc/launchpad-scripts.txt
183@@ -6,10 +6,6 @@ lp.services.scripts.base. This, along with the LaunchpadCronScript
184 specialization, implement common behaviour for all Launchpad command
185 line scripts.
186
187- >>> from lp.services.scripts.base import (
188- ... LaunchpadScript, LaunchpadCronScript)
189-
190-
191 Scripts report their executution using the standard Python logging
192 module, with command line arguments and logging setup provided by
193 LaunchpadScript. Unhandled exceptions from scripts are automatically
194diff --git a/lib/lp/services/webservice/doc/webservice-error.txt b/lib/lp/services/webservice/doc/webservice-error.txt
195index 5cf4404..47d6b31 100644
196--- a/lib/lp/services/webservice/doc/webservice-error.txt
197+++ b/lib/lp/services/webservice/doc/webservice-error.txt
198@@ -4,7 +4,6 @@ Most of the time, if a web service client triggers an exception, the
199 response code will be 500. But specific exception classes can override
200 this behaviour and set some other response code.
201
202- >>> import threading
203 >>> from lp.services.webapp.servers import LaunchpadTestRequest
204 >>> from lp.services.webapp.adapter import (
205 ... set_request_started, clear_request_started)
206diff --git a/lib/lp/translations/stories/standalone/xx-pofile-translate-dismiss-suggestions.txt b/lib/lp/translations/stories/standalone/xx-pofile-translate-dismiss-suggestions.txt
207index e5fec7a..1187bda 100644
208--- a/lib/lp/translations/stories/standalone/xx-pofile-translate-dismiss-suggestions.txt
209+++ b/lib/lp/translations/stories/standalone/xx-pofile-translate-dismiss-suggestions.txt
210@@ -5,7 +5,6 @@ translation of a message. If the current translation is good enough, new
211 suggestions can be dismissed to keep them off the page.
212
213 >>> from zope.component import getUtility
214- >>> from lp.testing.pages import extract_url_parameter
215 >>> from lp.translations.interfaces.potemplate import IPOTemplateSet
216
217 >>> login(ANONYMOUS)

Subscribers

People subscribed via source and target branches

to status/vote changes: