Merge ~cjwatson/launchpad:archive-append-mark-suite-dirty into launchpad:master
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Colin Watson | ||||
Approved revision: | ad9c75b7a01c564d6378980c834dc2db45512d5d | ||||
Merge reported by: | Otto Co-Pilot | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~cjwatson/launchpad:archive-append-mark-suite-dirty | ||||
Merge into: | launchpad:master | ||||
Diff against target: |
106 lines (+48/-22) 2 files modified
lib/lp/soyuz/interfaces/archive.py (+20/-20) lib/lp/soyuz/tests/test_archive.py (+28/-2) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cristian Gonzalez (community) | Approve | ||
Review via email: mp+405379@code.launchpad.net |
Commit message
Move markSuiteDirty to IArchiveAppend
Description of the change
`markSuiteDirty` allows forcing a suite in an archive to be republished as if by an upload without actually uploading to it. It was previously in `IArchiveEdit`, which requires the distribution owner in the case of primary archives and the archive owner in all other cases. This turns out to be inconvenient in practice for Ubuntu, where the archive owner is ~ubuntu-archive and handles day-to-day archive administration work, and the distribution owner is ~techboard which doesn't.
There isn't an obvious perfect fit here, but `IArchiveAppend` seems a lot closer: it requires the archive owner or somebody with upload permission in the case of PPAs, and the archive owner in all other cases. The only significant downside is that Launchpad administrators won't be able to use it any more, but I think this is tolerable. If it becomes a problem, we can probably press the `launchpad.Owner` permission into service, since it's currently unused for archives.
Looks good!