Launchpad itself

Merge ~cjwatson/launchpad:latest-uploads-extra-query into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. latest-uploads-extra-query
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: f12767cb45c2ab739274f4d11043f9cfe0bc6237
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:latest-uploads-extra-query
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/lp/soyuz/templates/distroseries-portlet-latestuploads.pt (+1/-1)
Reviewer Review Type Date Requested Status
Ioana Lasc (community) Approve
Review via email: mp+403825@code.launchpad.net

Commit message

Remove extra query from DistroSeries:+portlet-latestuploads

Description of the change

`DistroSeries.getLatestUploads` is still relatively slow even after recent optimizations, so it's worth avoiding calling it twice unnecessarily.

To post a comment you must log in.
Revision history for this message
Ioana Lasc (ilasc) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/soyuz/templates/distroseries-portlet-latestuploads.pt b/lib/lp/soyuz/templates/distroseries-portlet-latestuploads.pt
2index 6028ca7..bd39aaf 100644
3--- a/lib/lp/soyuz/templates/distroseries-portlet-latestuploads.pt
4+++ b/lib/lp/soyuz/templates/distroseries-portlet-latestuploads.pt
5@@ -13,7 +13,7 @@
6
7 <ul id="latest-uploads" class="binary package"
8 tal:condition="latest_uploads">
9- <li tal:repeat="source context/getLatestUploads">
10+ <li tal:repeat="source latest_uploads">
11 <a
12 tal:attributes="href source/fmt:url"
13 tal:content="source/displayname" />

Subscribers

People subscribed via source and target branches

to status/vote changes: