Merge ~cjwatson/launchpad:js-edit-comment-whitespace into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 9a91290746d3f7b0cbb94202261d1c6c9d6cfa9c
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:js-edit-comment-whitespace
Merge into: launchpad:master
Diff against target: 26 lines (+2/-2)
2 files modified
lib/lp/services/messages/javascript/messages.edit.js (+1/-1)
lib/lp/services/messages/javascript/tests/test_messages.edit.js (+1/-1)
Reviewer Review Type Date Requested Status
Thiago F. Pappacena (community) Approve
Review via email: mp+403394@code.launchpad.net

Commit message

Tweak whitespace when editing a comment via JS

To post a comment you must log in.
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

LGTM! Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/services/messages/javascript/messages.edit.js b/lib/lp/services/messages/javascript/messages.edit.js
2index f84bf72..c6e79b6 100644
3--- a/lib/lp/services/messages/javascript/messages.edit.js
4+++ b/lib/lp/services/messages/javascript/messages.edit.js
5@@ -155,7 +155,7 @@ YUI.add('lp.services.messages.edit', function(Y) {
6 elements.update_btn.getDOMNode().disabled = false;
7 module.hideLoading(elements.container);
8 elements.last_edit.getDOMNode().innerHTML = (
9- '<a href="#" class="editable-message-last-edit-link">' +
10+ ' <a href="#" class="editable-message-last-edit-link">' +
11 '(last edit a moment ago):' +
12 '</a>');
13
14diff --git a/lib/lp/services/messages/javascript/tests/test_messages.edit.js b/lib/lp/services/messages/javascript/tests/test_messages.edit.js
15index 5d12dab..f5cbd39 100644
16--- a/lib/lp/services/messages/javascript/tests/test_messages.edit.js
17+++ b/lib/lp/services/messages/javascript/tests/test_messages.edit.js
18@@ -169,7 +169,7 @@ YUI.add('lp.services.messages.edit.test', function(Y) {
19 // Check that the "last edit" header changed.
20 Y.Assert.areSame(":", this.last_edit[0].getDOMNode().innerHTML);
21 Y.Assert.areSame(
22- '<a href="#" class="editable-message-last-edit-link">' +
23+ ' <a href="#" class="editable-message-last-edit-link">' +
24 '(last edit a moment ago):</a>',
25 this.last_edit[1].getDOMNode().innerHTML);
26 },

Subscribers

People subscribed via source and target branches

to status/vote changes: