Launchpad itself

Merge ~cjwatson/launchpad:py3-mailing-list-xmlrpc-test-warning into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. py3-mailing-list-xmlrpc-test-warning
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: ea360bb6c82a6d20b2a48b30c3825e21bd5f9ea7
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:py3-mailing-list-xmlrpc-test-warning
Merge into: launchpad:master
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/registry/tests/test_xmlrpc.py (+1/-1)
Reviewer Review Type Date Requested Status
Cristian Gonzalez (community) Approve
Review via email: mp+403389@code.launchpad.net

Commit message

Correct spelling of \-escape in TestMailingListXMLRPCMessage

Description of the change

This fixes a DeprecationWarning with Python >= 3.6.

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/registry/tests/test_xmlrpc.py b/lib/lp/registry/tests/test_xmlrpc.py
2index 11da72f..cfc665c 100644
3--- a/lib/lp/registry/tests/test_xmlrpc.py
4+++ b/lib/lp/registry/tests/test_xmlrpc.py
5@@ -192,7 +192,7 @@ class TestMailingListXMLRPCMessage(TestCaseWithFactory):
6 'New mailing list message requiring approval for Team',
7 notifications[0]['subject'])
8 self.assertTextMatchesExpressionIgnoreWhitespace(
9- '.*http://launchpad.test/~team/\+mailinglist-moderate.*',
10+ r'.*http://launchpad.test/~team/\+mailinglist-moderate.*',
11 notifications[0].get_payload())
12 self.assertEqual({}, self.rpc_proxy.getMessageDispositions())
13

Subscribers

People subscribed via source and target branches

to status/vote changes: