Merge ~cjwatson/launchpad:tracer-action-leak into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | cfc08c8c41f53c42d96f84432b89c622a673bfeb |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:tracer-action-leak |
Merge into: | launchpad:master |
Diff against target: |
48 lines (+22/-0) 2 files modified
lib/lp/services/webapp/adapter.py (+2/-0) lib/lp/services/webapp/tests/test_statementtracer.py (+20/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cristian Gonzalez (community) | Approve | ||
Review via email: mp+403272@code.launchpad.net |
Commit message
Clear connection.
Description of the change
Since database connections are typically cached, leaving TimedAction references lying around on them makes life more difficult for the cyclic garbage collector and makes it harder to track down memory leaks.
To post a comment you must log in.
Looks good!