Launchpad itself

Merge ~cjwatson/launchpad:close-account-import-policy into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. close-account-import-policy
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 98b0648609b98f4d001589108c2fb84db63298b1
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:close-account-import-policy
Merge into: launchpad:master
Diff against target: 16 lines (+4/-1)
1 file modified
lib/lp/registry/scripts/closeaccount.py (+4/-1)
Reviewer Review Type Date Requested Status
Ioana Lasc (community) Approve
Review via email: mp+401125@code.launchpad.net

Commit message

Add close_account to lp.registry.scripts.closeaccount.__all__

Description of the change

Fixes:

    There were 1 imports of names not appearing in the __all__.
    You should not import close_account from lp.registry.scripts.closeaccount:
        lp.registry.model.persontransferjob

To post a comment you must log in.
Revision history for this message
Ioana Lasc (ilasc) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/registry/scripts/closeaccount.py b/lib/lp/registry/scripts/closeaccount.py
2index 6fa8585..27b2eb1 100644
3--- a/lib/lp/registry/scripts/closeaccount.py
4+++ b/lib/lp/registry/scripts/closeaccount.py
5@@ -4,7 +4,10 @@
6 """Remove personal details of a user from the database, leaving a stub."""
7
8 __metaclass__ = type
9-__all__ = ['CloseAccountScript']
10+__all__ = [
11+ 'close_account',
12+ 'CloseAccountScript',
13+ ]
14
15 import six
16 from storm.exceptions import IntegrityError

Subscribers

People subscribed via source and target branches

to status/vote changes: