Launchpad itself

Merge ~cjwatson/launchpad:clean-pip-remove-env into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. clean-pip-remove-env
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: c51702f9333489f83dac06381f415e737ae3a878
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:clean-pip-remove-env
Merge into: launchpad:master
Diff against target: 11 lines (+1/-0)
1 file modified
Makefile (+1/-0)
Reviewer Review Type Date Requested Status
Tom Wardill (community) Approve
Review via email: mp+401034@code.launchpad.net

Commit message

Remove env/ directory in "make clean_pip"

Description of the change

This target is used as part of the wheel-building machinery for production deployments. If we leave the env/ directory in place after building wheels, then pushing code can get confused: since env/ still exists, it thinks it doesn't need to rebuild it, but bin/ has been removed so the tree won't work until it's been rebuilt.

To post a comment you must log in.
Revision history for this message
Tom Wardill (twom) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Makefile b/Makefile
2index 5466ef7..0c824f8 100644
3--- a/Makefile
4+++ b/Makefile
5@@ -414,6 +414,7 @@ clean_pip:
6 $(RM) -r build
7 if [ -d $(CONVOY_ROOT) ]; then $(RM) -r $(CONVOY_ROOT) ; fi
8 $(RM) -r bin
9+ $(RM) -r env
10 $(RM) -r parts
11 $(RM) .installed.cfg
12

Subscribers

People subscribed via source and target branches

to status/vote changes: