Launchpad itself

Merge ~cjwatson/launchpad:py3-sourcepackage-index-binaries into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. py3-sourcepackage-index-binaries
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: b18c22fef9a057aeeb64cebf6f9642952d9f637d
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:py3-sourcepackage-index-binaries
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/lp/registry/templates/sourcepackage-index.pt (+1/-1)
Reviewer Review Type Date Requested Status
Cristian Gonzalez (community) Approve
Review via email: mp+399191@code.launchpad.net

Commit message

Sort binaries on SourcePackage:+index

Description of the change

Tests sometimes fail on Python 3 otherwise. It's probably most natural to sort the binaries lexicographically by name.

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/registry/templates/sourcepackage-index.pt b/lib/lp/registry/templates/sourcepackage-index.pt
2index d91e265..df85b88 100644
3--- a/lib/lp/registry/templates/sourcepackage-index.pt
4+++ b/lib/lp/registry/templates/sourcepackage-index.pt
5@@ -86,7 +86,7 @@
6
7 <div id="binaries" tal:define="binaries view/binaries">
8 <ul tal:condition="binaries">
9- <li tal:repeat="bin_name binaries">
10+ <li tal:repeat="bin_name python:sorted(binaries)">
11 <span tal:replace="bin_name" />
12 <span tal:repeat="archtag python:binaries[bin_name]">
13 (<a tal:content="archtag" tal:attributes="href

Subscribers

People subscribed via source and target branches

to status/vote changes: