Merge ~cjwatson/launchpad:py3-test-checkForNewBuilders into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 97e7ce4b6653c12d6890c8583cea3ff4e21c23d2
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:py3-test-checkForNewBuilders
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/lp/buildmaster/tests/test_manager.py (+1/-1)
Reviewer Review Type Date Requested Status
Cristian Gonzalez (community) Approve
Review via email: mp+398980@code.launchpad.net

Commit message

Fix test_checkForNewBuilders for Python 3

Description of the change

New builder names aren't returned in any particular order, so we need to use `assertContentEqual` rather than just `assertEqual`.

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/buildmaster/tests/test_manager.py b/lib/lp/buildmaster/tests/test_manager.py
2index 6b8c8d5..4dc6b47 100644
3--- a/lib/lp/buildmaster/tests/test_manager.py
4+++ b/lib/lp/buildmaster/tests/test_manager.py
5@@ -1430,7 +1430,7 @@ class TestNewBuilders(TestCase):
6 factory = LaunchpadObjectFactory()
7 for builder_name in new_builders:
8 factory.makeBuilder(name=builder_name)
9- self.assertEqual(new_builders, manager.checkForNewBuilders())
10+ self.assertContentEqual(new_builders, manager.checkForNewBuilders())
11
12 def test_checkForNewBuilders_detects_builder_only_once(self):
13 # checkForNewBuilders() only detects a new builder once.

Subscribers

People subscribed via source and target branches

to status/vote changes: