Merge ~cjwatson/launchpad:py3-base64-types into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | ac80d2d37760f34a71254726bab51c220ecc79cc |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:py3-base64-types |
Merge into: | launchpad:master |
Diff against target: |
260 lines (+34/-28) 17 files modified
lib/lp/app/browser/stringformatter.py (+2/-1) lib/lp/archivepublisher/htaccess.py (+2/-1) lib/lp/code/scripts/tests/test_request_daily_builds.py (+4/-1) lib/lp/registry/model/person.py (+2/-2) lib/lp/registry/stories/team-polls/xx-poll-confirm-vote.txt (+2/-1) lib/lp/services/gpg/tests/test_gpghandler.py (+0/-6) lib/lp/services/signing/tests/test_proxy.py (+2/-3) lib/lp/services/webapp/doc/webapp-publication.txt (+1/-1) lib/lp/services/webapp/tests/test_authutility.py (+3/-3) lib/lp/services/webservice/stories/xx-service.txt (+3/-1) lib/lp/snappy/model/snapbuildbehaviour.py (+1/-1) lib/lp/snappy/model/snapstoreclient.py (+2/-2) lib/lp/soyuz/adapters/archivedependencies.py (+2/-1) lib/lp/soyuz/tests/soyuz.py (+1/-1) lib/lp/testing/factory.py (+2/-1) utilities/massage-bug-import-xml (+2/-1) utilities/roundup-sniffer.py (+3/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cristian Gonzalez (community) | Approve | ||
Review via email: mp+398930@code.launchpad.net |
Commit message
Use correct types for base64 encoding/decoding
Description of the change
On Python 3, base64.b64encode takes bytes and returns bytes. base64.b64decode in fact takes either bytes or ASCII-only Unicode strings and returns bytes, but it's more symmetrical and thus clearer to treat it as if it only took bytes.
To post a comment you must log in.
Looks good!