Merge ~cjwatson/launchpad:py3-test-sprints-stringio into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 5cbb02017968192b2714a3bb0cc40c9a2da90db4
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:py3-test-sprints-stringio
Merge into: launchpad:master
Diff against target: 23 lines (+2/-3)
1 file modified
lib/lp/blueprints/stories/sprints/xx-sprints.txt (+2/-3)
Reviewer Review Type Date Requested Status
Cristian Gonzalez (community) Approve
Review via email: mp+398926@code.launchpad.net

Commit message

Port xx-sprints.txt to six.StringIO

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/blueprints/stories/sprints/xx-sprints.txt b/lib/lp/blueprints/stories/sprints/xx-sprints.txt
2index f1b0ced..cfda51f 100644
3--- a/lib/lp/blueprints/stories/sprints/xx-sprints.txt
4+++ b/lib/lp/blueprints/stories/sprints/xx-sprints.txt
5@@ -489,8 +489,7 @@ First, we add a couple of IRC nicknames for Carlos.
6 The resulting CSV file lists physical attendance correctly.
7
8 >>> import csv
9- >>> from StringIO import StringIO
10- >>> ubz_csv = list(csv.DictReader(StringIO(browser.contents)))
11+ >>> ubz_csv = list(csv.DictReader(six.StringIO(browser.contents)))
12 >>> [(row["Launchpad username"], row["Physically present"])
13 ... for row in ubz_csv]
14 [('carlos', 'True'), ('salgado', 'False'), ('name12', 'True')]
15@@ -523,7 +522,7 @@ as attending remotely.
16 >>> browser.getControl('Register').click()
17
18 >>> browser.getLink('Export attendees to CSV').click()
19- >>> ltsp_csv = list(csv.DictReader(StringIO(browser.contents)))
20+ >>> ltsp_csv = list(csv.DictReader(six.StringIO(browser.contents)))
21 >>> [(row["Launchpad username"], row["Physically present"])
22 ... for row in ltsp_csv]
23 [('name12', 'False')]

Subscribers

People subscribed via source and target branches

to status/vote changes: