Merge ~cjwatson/launchpad:py3-dict-iteration into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | b5188787cc001bbf9673ca41ff55c5c21c75f41b |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:py3-dict-iteration |
Merge into: | launchpad:master |
Diff against target: |
12 lines (+1/-1) 1 file modified
lib/lp/bugs/externalbugtracker/bugzilla.py (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cristian Gonzalez (community) | Approve | ||
Review via email: mp+398923@code.launchpad.net |
Commit message
Avoid changing a dict while iterating over it
Description of the change
This breaks in Python 3, since dict.items() now returns a view rather than materializing a list up-front.
To post a comment you must log in.
Looks good!