Merge ~cjwatson/launchpad:py3-test-bugtask-expiration into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: d39f7e68d487f0ae3ccadc738268b0b4f3975821
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:py3-test-bugtask-expiration
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/lp/bugs/doc/bugtask-expiration.txt (+1/-1)
Reviewer Review Type Date Requested Status
Cristian Gonzalez (community) Approve
Review via email: mp+398703@code.launchpad.net

Commit message

Fix bugtask-expiration.txt for Python 3

Description of the change

Python 3.5 raises this exception instead:

  TypeError: findExpirableBugTasks() missing 2 required positional arguments: 'min_days_old' and 'user'

We don't really care about the fine details.

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/bugs/doc/bugtask-expiration.txt b/lib/lp/bugs/doc/bugtask-expiration.txt
2index 4ff1d08..f34bb17 100644
3--- a/lib/lp/bugs/doc/bugtask-expiration.txt
4+++ b/lib/lp/bugs/doc/bugtask-expiration.txt
5@@ -43,7 +43,7 @@ status. It also requires specifying the user that is doing the search.
6 >>> expirable_bugtasks = bugtaskset.findExpirableBugTasks()
7 Traceback (most recent call last):
8 ...
9- TypeError: findExpirableBugTasks() takes at least 3 arguments (1 given)
10+ TypeError: findExpirableBugTasks() ...
11
12 Looking back 9,999 days, findExpirableBugTasks() reports that there are
13 no expirable bugtasks in the sampledata.

Subscribers

People subscribed via source and target branches

to status/vote changes: