Launchpad itself

Merge ~cjwatson/launchpad:py3-scoping into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. py3-scoping
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 1a8139f5cb95d6e5961de370eb2593e135b0adfc
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:py3-scoping
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/lp/bugs/tests/test_bugsearch_conjoined.py (+1/-1)
Reviewer Review Type Date Requested Status
Cristian Gonzalez (community) Approve
Review via email: mp+398378@code.launchpad.net

Commit message

Fix TestProjectGroupExcludeConjoinedMasterSearch for Python 3

Description of the change

This failed due to tighter scoping rules.

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/bugs/tests/test_bugsearch_conjoined.py b/lib/lp/bugs/tests/test_bugsearch_conjoined.py
2index eb7fc01..faf1e7f 100644
3--- a/lib/lp/bugs/tests/test_bugsearch_conjoined.py
4+++ b/lib/lp/bugs/tests/test_bugsearch_conjoined.py
5@@ -237,7 +237,7 @@ class TestProjectGroupExcludeConjoinedMasterSearch(TestSearchBase):
6 unexcluded_count = 0
7 for bugtask in masters:
8 unexcluded_count += 1
9- with person_logged_in(product.owner):
10+ with person_logged_in(bugtask.target.owner):
11 bugtask.transitionToStatus(
12 BugTaskStatus.WONTFIX, bugtask.target.owner)
13 self.assertEqual(

Subscribers

People subscribed via source and target branches

to status/vote changes: