Launchpad itself

Merge ~cjwatson/launchpad:py3-RunJobCommand into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. py3-RunJobCommand
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 0987857af67f0f0aa8c32e4a54853b5b0473fb3c
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:py3-RunJobCommand
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/lp/services/job/runner.py (+1/-1)
Reviewer Review Type Date Requested Status
Cristian Gonzalez (community) Approve
Review via email: mp+398376@code.launchpad.net

Commit message

RunJobCommand: Treat oops_id as text

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/services/job/runner.py b/lib/lp/services/job/runner.py
2index 4d302d5..5368050 100644
3--- a/lib/lp/services/job/runner.py
4+++ b/lib/lp/services/job/runner.py
5@@ -451,7 +451,7 @@ class JobRunner(BaseJobRunner):
6 class RunJobCommand(amp.Command):
7
8 arguments = [(b'job_id', amp.Integer())]
9- response = [(b'success', amp.Integer()), (b'oops_id', amp.String())]
10+ response = [(b'success', amp.Integer()), (b'oops_id', amp.Unicode())]
11
12
13 def import_source(job_source_name):

Subscribers

People subscribed via source and target branches

to status/vote changes: