Merge ~cjwatson/launchpad:stormbase-eq-hash into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 6f2a36c1e74d99f511b033c19273c4cb2b67c6c4 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:stormbase-eq-hash |
Merge into: | launchpad:master |
Diff against target: |
91 lines (+51/-3) 2 files modified
lib/lp/services/database/stormbase.py (+49/-2) lib/lp/services/database/tests/test_collection.py (+2/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cristian Gonzalez (community) | Approve | ||
Review via email: mp+398087@code.launchpad.net |
Commit message
Implement __eq__, __ne__, and __hash__ for StormBase
Description of the change
This matches SQLBase: it's much less confusing if converting a model to Storm doesn't quietly change its equality and hashing semantics.
To post a comment you must log in.
Looks good!