Merge ~cjwatson/launchpad:fix-miscompiled-pofile-query into launchpad:master
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Colin Watson | ||||
Approved revision: | 49064791591257da0a00980472d12e8f5cf21ad4 | ||||
Merge reported by: | Otto Co-Pilot | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~cjwatson/launchpad:fix-miscompiled-pofile-query | ||||
Merge into: | launchpad:master | ||||
Diff against target: |
20 lines (+2/-2) 1 file modified
lib/lp/translations/model/pofile.py (+2/-2) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thiago F. Pappacena (community) | Approve | ||
Review via email: mp+395934@code.launchpad.net |
Commit message
Fix miscompiled query in POFileMixin.
Description of the change
Converting POFile queries to Storm (https:/
tm_ids = ClassAlias(
tm_ids.language == pofile.language
... is compiled to "TranslationMes
I haven't worked out how to test this automatically (or even whether it results in a different set of rows rather than merely a much slower query), but I've manually tested on staging that the modified query performs reasonably again.
LGTM. Good catch!