Launchpad itself

Merge ~cjwatson/launchpad:py3-bugtaskview-activity-and-comments into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. py3-bugtaskview-activity-and-comments
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 3eda127054c85582a946ab052bb053ee438303f3
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:py3-bugtaskview-activity-and-comments
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/lp/bugs/browser/bugtask.py (+1/-1)
Reviewer Review Type Date Requested Status
Ioana Lasc (community) Approve
Review via email: mp+394987@code.launchpad.net

Commit message

Fix BugTaskView.activity_and_comments for Python 3

Description of the change

map() returns an iterator in Python 3 rather than a list.

To post a comment you must log in.
Revision history for this message
Ioana Lasc (ilasc) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/bugs/browser/bugtask.py b/lib/lp/bugs/browser/bugtask.py
2index c6bc9d7..66f2231 100644
3--- a/lib/lp/bugs/browser/bugtask.py
4+++ b/lib/lp/bugs/browser/bugtask.py
5@@ -728,7 +728,7 @@ class BugTaskView(LaunchpadView, BugViewMixin, FeedsMixin):
6 else:
7 return comment_event_dict(event_group)
8
9- events = map(event_dict, event_groups)
10+ events = [event_dict(event_group) for event_group in event_groups]
11
12 # Insert blanks if we're showing only a subset of the comment list.
13 if self.visible_comments_truncated_for_display:

Subscribers

People subscribed via source and target branches

to status/vote changes: