Merge ~cjwatson/launchpad:sync-signingkeys-optimise into launchpad:master

[Colin Watson]

Don't materialise all archives in sync-signingkeys

I added this list() call due to an inchoate thought that it might be needed to do stable iteration over the list of archives, but in fact there's no good reason for that since we're ordering by Archive.id anyway. Loading all the archives into the Storm cache up-front made commits unreasonably slow.

[Tom Wardill (twom)]

review: Approve

diff --git a/lib/lp/archivepublisher/scripts/sync_signingkeys.py b/lib/lp/archivepublisher/scripts/sync_signingkeys.py
index b3c4e72..a56978e 100644
--- a/lib/lp/archivepublisher/scripts/sync_signingkeys.py
+++ b/lib/lp/archivepublisher/scripts/sync_signingkeys.py
@@ -255,9 +255,8 @@ class SyncSigningKeysScript(LaunchpadScript):
             transaction.commit()
 
     def main(self):
-        archives = list(self.getArchives())
         total = 0
-        for i, archive in enumerate(archives):
+        for i, archive in enumerate(self.getArchives()):
             if i != 0 and i % 100 == 0:
                 self._maybeCommit(i)
             self.logger.debug(