Merge ~cjwatson/launchpad:py3-readline-libedit-workaround into launchpad:master
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 731e8cc9934a16eb88858770ca2498637689169c |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:py3-readline-libedit-workaround |
Merge into: | launchpad:master |
Diff against target: |
54 lines (+18/-0) 2 files modified
lib/lp/scripts/utilities/test.py (+17/-0) setup.py (+1/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tom Wardill (community) | Approve | ||
Review via email: mp+392028@code.launchpad.net |
Commit message
Work around readline crash in Python 3 on 18.04
Description of the change
On 18.04, importing GTK (which we do in lp.testing.
There's unfortunately no reasonable way to avoid this, because we aren't loading libedit directly and nor are we importing readline directly; they're both quite deeply-buried side-effects of other things. We have to take an unreasonable way instead: stub out the readline module in the test suite on affected systems. This is deliberately kept as narrow as possible, and we should drop it if and when the Python bug is fixed in Ubuntu 18.04 or we no longer care about trying to get Launchpad to run on Python 3 on 18.04.