Merge ~cjwatson/launchpad:code-import-scheduler-librarian into launchpad:master
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | eaec2406b72f3acb41eca1ba0722d0f1c378d5e4 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:code-import-scheduler-librarian |
Merge into: | launchpad:master |
Diff against target: |
130 lines (+52/-8) 3 files modified
lib/lp/code/interfaces/codeimportscheduler.py (+7/-1) lib/lp/code/xmlrpc/codeimportscheduler.py (+21/-6) lib/lp/code/xmlrpc/tests/test_codeimportscheduler.py (+24/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ioana Lasc (community) | Approve | ||
Review via email: mp+391793@code.launchpad.net |
Commit message
Accept code import log file data over XML-RPC
Description of the change
The code import worker currently uploads its log file directly to the librarian. This is a bit of an obstacle to splitting out the code import worker from the main Launchpad codebase: it wouldn't necessarily be impossible to retain the remote librarian upload client in a future lp-codeimport, but it would be somewhat awkward as that client is currently designed with the expectation of having direct Launchpad database access.
Log files aren't typically all that large, though, so it seems workable to just send them as part of the XML-RPC `finishJobID` request and have the webapp side of that request do the librarian upload instead. This prepares for that by accepting either XML-RPC-