Merge ~cjwatson/launchpad:py3-packageuploadnotificationjob-bytesio into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 855c978ea5f20d0bb8c19e9e7597405b4d6d6644
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:py3-packageuploadnotificationjob-bytesio
Merge into: launchpad:master
Diff against target: 24 lines (+2/-3)
1 file modified
lib/lp/soyuz/model/archivejob.py (+2/-3)
Reviewer Review Type Date Requested Status
Thiago F. Pappacena (community) Approve
Review via email: mp+391160@code.launchpad.net

Commit message

Port PackageUploadNotificationJob to BytesIO

To post a comment you must log in.
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/soyuz/model/archivejob.py b/lib/lp/soyuz/model/archivejob.py
2index b691683..d0ed964 100644
3--- a/lib/lp/soyuz/model/archivejob.py
4+++ b/lib/lp/soyuz/model/archivejob.py
5@@ -3,8 +3,8 @@
6
7 __metaclass__ = type
8
9+import io
10 import logging
11-import StringIO
12
13 from lazr.delegates import delegate_to
14 import six
15@@ -165,8 +165,7 @@ class PackageUploadNotificationJob(ArchiveJobDerived):
16 if packageupload.changesfile is None:
17 changes_file_object = None
18 else:
19- changes_file_object = StringIO.StringIO(
20- packageupload.changesfile.read())
21+ changes_file_object = io.BytesIO(packageupload.changesfile.read())
22 logger = logging.getLogger()
23 packageupload.notify(
24 status=self.packageupload_status, summary_text=self.summary_text,

Subscribers

People subscribed via source and target branches

to status/vote changes: