Merge ~cjwatson/launchpad:spokenin-zcml into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 2df679370ef0efa6f982e1c4fa9887f0c468904c
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:spokenin-zcml
Merge into: launchpad:master
Diff against target: 33 lines (+5/-6)
2 files modified
lib/lp/services/worlddata/configure.zcml (+5/-0)
lib/lp/services/worlddata/model/language.py (+0/-6)
Reviewer Review Type Date Requested Status
Thiago F. Pappacena (community) Approve
Review via email: mp+390836@code.launchpad.net

Commit message

Import SpokenIn from ZCML

Description of the change

This allows us to remove the otherwise-unused import of it in lp.services.worlddata.model.language.

To post a comment you must log in.
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/services/worlddata/configure.zcml b/lib/lp/services/worlddata/configure.zcml
2index a3a8bf7..f705487 100644
3--- a/lib/lp/services/worlddata/configure.zcml
4+++ b/lib/lp/services/worlddata/configure.zcml
5@@ -56,6 +56,11 @@
6 factory="lp.translations.browser.language.LanguageSetBreadcrumb"
7 permission="zope.Public"/>
8
9+ <class class=".model.spokenin.SpokenIn">
10+ <allow
11+ interface=".interfaces.spokenin.ISpokenIn" />
12+ </class>
13+
14 <include package=".browser"/>
15
16 <webservice:register module="lp.services.worlddata.interfaces.webservice" />
17diff --git a/lib/lp/services/worlddata/model/language.py b/lib/lp/services/worlddata/model/language.py
18index 9cb3c36..6b6ba5a 100644
19--- a/lib/lp/services/worlddata/model/language.py
20+++ b/lib/lp/services/worlddata/model/language.py
21@@ -48,12 +48,6 @@ from lp.services.worlddata.interfaces.language import (
22 ILanguageSet,
23 TextDirection,
24 )
25-# XXX: JonathanLange 2010-11-10 bug=673796: It turns out this module is
26-# unusable without spokenin being imported first. So, import spokenin.
27-from lp.services.worlddata.model.spokenin import SpokenIn
28-
29-
30-SpokenIn
31
32
33 @implementer(ILanguage)

Subscribers

People subscribed via source and target branches

to status/vote changes: