Merge ~cjwatson/launchpad:testfix-remove-hwdb-person into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 091563a0f4de5e901fcb0e5ea652a7ee80b26604
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:testfix-remove-hwdb-person
Merge into: launchpad:master
Diff against target: 43 lines (+0/-24)
2 files modified
lib/lp/hardwaredb/doc/hwdb.txt (+0/-7)
lib/lp/hardwaredb/stories/webservice/xx-hwdb.txt (+0/-17)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+390127@code.launchpad.net

Commit message

testfix: Remove uses of Person.hardware_submissions in tests

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Self-approving as a straightforward test-only follow-up to https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/389983.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/hardwaredb/doc/hwdb.txt b/lib/lp/hardwaredb/doc/hwdb.txt
2index 6fc2582..a29c585 100644
3--- a/lib/lp/hardwaredb/doc/hwdb.txt
4+++ b/lib/lp/hardwaredb/doc/hwdb.txt
5@@ -737,10 +737,3 @@ And we can also search for submissions from a particular user.
6 >>> set(submission.owner.name for submission
7 ... in hw_submission_set.search(owner=owner))
8 set([u'name12'])
9-
10-Alternatively, we can get the same result by looking at
11-IPerson.hardware_submissions.
12-
13- >>> set(submission.owner.name for submission
14- ... in owner.hardware_submissions)
15- set([u'name12'])
16diff --git a/lib/lp/hardwaredb/stories/webservice/xx-hwdb.txt b/lib/lp/hardwaredb/stories/webservice/xx-hwdb.txt
17index 73194eb..48cb6d4 100644
18--- a/lib/lp/hardwaredb/stories/webservice/xx-hwdb.txt
19+++ b/lib/lp/hardwaredb/stories/webservice/xx-hwdb.txt
20@@ -695,23 +695,6 @@ We can query for submissions from a particular user.
21 >>> print(submissions['total_size'])
22 0
23
24-=== Getting all submissions for a user ===
25-
26-We can get all of a user's hardware submissions by retrieving their
27-`hardware_submissions` collection.
28-
29- >>> name12 = webservice.get(webservice.getAbsoluteUrl('/~name12')).jsonBody()
30- >>> pprint_collection(
31- ... webservice.get(
32- ... name12['hardware_submissions_collection_link']).jsonBody())
33- resource_type_link: u'http://.../#h_w_submission-page-resource'
34- start: 0
35- total_size: 2
36- ...
37- submission_key: u'sample-submission'
38- ...
39-
40-
41 === Searching for submissions ===
42
43 Alternatively, we can also search for hardware submissions by user:

Subscribers

People subscribed via source and target branches

to status/vote changes: