Launchpad itself

Merge ~cjwatson/launchpad:py3-amp-commands into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. py3-amp-commands
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 34e3cd40e11d2ffd37cf0bb0aab3d9fcf38d6c0d
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:py3-amp-commands
Merge into: launchpad:master
Diff against target: 15 lines (+2/-2)
1 file modified
lib/lp/services/job/runner.py (+2/-2)
Reviewer Review Type Date Requested Status
Thiago F. Pappacena (community) Approve
Review via email: mp+387773@code.launchpad.net

Commit message

Make RunJobCommand argument and response names bytes

Description of the change

This is required in Python 3.

To post a comment you must log in.
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/services/job/runner.py b/lib/lp/services/job/runner.py
2index 8f80294..9ac7863 100644
3--- a/lib/lp/services/job/runner.py
4+++ b/lib/lp/services/job/runner.py
5@@ -426,8 +426,8 @@ class JobRunner(BaseJobRunner):
6
7 class RunJobCommand(amp.Command):
8
9- arguments = [('job_id', amp.Integer())]
10- response = [('success', amp.Integer()), ('oops_id', amp.String())]
11+ arguments = [(b'job_id', amp.Integer())]
12+ response = [(b'success', amp.Integer()), (b'oops_id', amp.String())]
13
14
15 def import_source(job_source_name):

Subscribers

People subscribed via source and target branches

to status/vote changes: