Merge ~cjwatson/launchpad:testfix-stormify-translationimportqueueentry into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: e50183691e669cf9769bd7199cfd31fbf3577144
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:testfix-stormify-translationimportqueueentry
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/lp/registry/tests/test_product.py (+1/-1)
Reviewer Review Type Date Requested Status
Tom Wardill (community) Approve
Review via email: mp+385680@code.launchpad.net

Commit message

Fix TestProduct.test_checkInformationType_queued_translations

Description of the change

entry.delete(entry.id) is a SQLObject-ism; use Store.of(entry).remove(entry) instead.

To post a comment you must log in.
Revision history for this message
Tom Wardill (twom) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/registry/tests/test_product.py b/lib/lp/registry/tests/test_product.py
2index 61442a4..e70fbbc 100644
3--- a/lib/lp/registry/tests/test_product.py
4+++ b/lib/lp/registry/tests/test_product.py
5@@ -587,7 +587,7 @@ class TestProduct(TestCaseWithFactory):
6 CannotChangeInformationType,
7 'This project has queued translations.'):
8 raise error
9- removeSecurityProxy(entry).delete(entry.id)
10+ Store.of(entry).remove(entry)
11 with person_logged_in(product.owner):
12 for info_type in PRIVATE_PROJECT_TYPES:
13 self.assertContentEqual(

Subscribers

People subscribed via source and target branches

to status/vote changes: