Launchpad itself

Merge ~cjwatson/launchpad:testfix-stormify-bugnotification into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. testfix-stormify-bugnotification
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 0ed8a1e6bdc7719a5860ae6e44be83a3d9615f8e
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:testfix-stormify-bugnotification
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/lp/registry/doc/milestone.txt (+1/-1)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+385675@code.launchpad.net

Commit message

Fix milestone.txt test failure

Description of the change

I made a mistake while converting BugNotification to Storm: unlike [-1] in SQLObject, Storm's last() method checks that the result set is ordered.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Self-approving trivial test fix.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/registry/doc/milestone.txt b/lib/lp/registry/doc/milestone.txt
2index 5e4b086..b413da9 100644
3--- a/lib/lp/registry/doc/milestone.txt
4+++ b/lib/lp/registry/doc/milestone.txt
5@@ -354,7 +354,7 @@ list of recipients.
6
7 >>> from lp.services.database.interfaces import IStore
8 >>> notification = IStore(BugNotification).find(
9- ... BugNotification, date_emailed=None).last()
10+ ... BugNotification, date_emailed=None).order_by('id').last()
11 >>> print notification.message.chunks[0].content
12 ** Changed in: firefox
13 Milestone: 1.0 => 2.0

Subscribers

People subscribed via source and target branches

to status/vote changes: