Merge ~cjwatson/launchpad:generalise-snap-build-base into launchpad:master
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Colin Watson | ||||
Approved revision: | 6a29280462f4f3d3f82bd8f4e356747e9ea06f3a | ||||
Merge reported by: | Otto Co-Pilot | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~cjwatson/launchpad:generalise-snap-build-base | ||||
Merge into: | launchpad:master | ||||
Diff against target: |
113 lines (+45/-10) 2 files modified
lib/lp/snappy/model/snap.py (+16/-7) lib/lp/snappy/tests/test_snap.py (+29/-3) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ioana Lasc (community) | Approve | ||
Review via email: mp+383436@code.launchpad.net |
Commit message
Implement build-base for snaps without base: bare
Description of the change
Sync up our base selection for snap builds with snapcraft:
https:/
This makes two significant changes to base selection:
* `build-base` now wins in all cases, even if the snap does not have `base: bare`;
* if `build-base` is not set and the snap has `type: base`, then the snap's `name` is used as the base.
If neither of those apply, then the value of `base` is used, as before.
`base: bare` without `build-base` is now an error, while previously the default base would have been used. However, this combination is forbidden by snapcraft at the schema-validation change, so this change shouldn't matter in practice.
looks good!