Merge ~cjwatson/launchpad:hwdb-disable-submissions into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | c73b4dc00f4faa02db0b73c6808056bff0cbd228 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:hwdb-disable-submissions |
Merge into: | launchpad:master |
Diff against target: |
235 lines (+110/-1) 8 files modified
lib/lp/hardwaredb/browser/configure.zcml (+7/-1) lib/lp/hardwaredb/browser/hwdb.py (+8/-0) lib/lp/hardwaredb/interfaces/hwdb.py (+19/-0) lib/lp/hardwaredb/model/hwdb.py (+6/-0) lib/lp/hardwaredb/stories/hwdb/xx-hwdb.txt (+21/-0) lib/lp/hardwaredb/templates/hwdb-submissions-disabled.pt (+19/-0) lib/lp/hardwaredb/tests/test_hwdb.py (+29/-0) lib/lp/services/webapp/error.py (+1/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kristian Glass (community) | Approve | ||
Review via email: mp+383158@code.launchpad.net |
Commit message
Add a feature flag to disable new hwdb submissions
Description of the change
Since Ubuntu xenial, checkbox no longer uses Launchpad's hardware database, and the only new submissions are coming from older systems; the certification teams no longer pay attention to it. Add a hardwaredb.
To post a comment you must log in.
Looks good to me, thanks
One inline non-blocking query about your doctest though