Merge ~cjwatson/launchpad:bug-attachment-removal-roles into launchpad:master
Proposed by
Colin Watson
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Colin Watson | ||||
Approved revision: | a4eb7199bfb5ac42c5b914fef1581abc6e3b6083 | ||||
Merge reported by: | Otto Co-Pilot | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~cjwatson/launchpad:bug-attachment-removal-roles | ||||
Merge into: | launchpad:master | ||||
Diff against target: |
153 lines (+48/-28) 2 files modified
lib/lp/bugs/browser/tests/test_bugattachment_edit_view.py (+24/-4) lib/lp/bugs/security.py (+24/-24) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thiago F. Pappacena (community) | Approve | ||
Review via email: mp+382608@code.launchpad.net |
Commit message
Allow people with bug target roles to edit attachments
Description of the change
In particular, this ensures that bug supervisors can edit attachments on bugs with corresponding tasks, which is needed by Ubuntu's retracers.
The implementation of this is borrowed from EditBug, and, as in that case, isn't particularly fast for bugs with many tasks. However, checking whether we can edit a bug attachment isn't a hot operation (in the UI, I don't believe we check this when viewing bugs, only on the page to edit an attachment), so we can continue to get away with this for the time being.
To post a comment you must log in.
LGTM! Thanks!