Merge ~cjwatson/launchpad:email-utf8-inline-comments into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | e172c36045dc582376276893e0652982208296ae |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:email-utf8-inline-comments |
Merge into: | launchpad:master |
Diff against target: |
62 lines (+8/-7) 2 files modified
lib/lp/code/mail/codereviewcomment.py (+3/-2) lib/lp/code/mail/tests/test_codereviewcomment.py (+5/-5) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kristian Glass (community) | Approve | ||
Review via email: mp+378414@code.launchpad.net |
Commit message
Fix emailing of non-ASCII inline comments
Description of the change
I think this regressed as part of my port of codehosting to Breezy. The tests didn't catch it because they were using \u escapes in non-Unicode string literals, which meant that e.g. \u03b4 was interpreted as the byte sequence '\', 'u', '0', '3', 'b', '4' rather than U+03B4.
To post a comment you must log in.
Cripes, that test-data issue is disconcertingly easy to run into!
LGTM