Merge ~cjwatson/launchpad:misc-breezy into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 9215d572f461de9c741102f9d0f1e0b98e7407d8
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:misc-breezy
Merge into: launchpad:master
Diff against target: 139 lines (+12/-14)
9 files modified
lib/lp/registry/browser/product.py (+2/-2)
lib/lp/registry/model/distributionsourcepackage.py (+1/-1)
lib/lp/scripts/utilities/importpedant.py (+0/-1)
lib/lp/services/profile/profile.py (+2/-2)
lib/lp/services/testing/parallel.py (+1/-1)
lib/lp/snappy/model/snap.py (+2/-3)
lib/lp/testing/pgsql.py (+2/-2)
lib/lp/testing/tests/test_pages.py (+1/-1)
utilities/get-branch-info (+1/-1)
Reviewer Review Type Date Requested Status
Ioana Lasc (community) Approve
Review via email: mp+377946@code.launchpad.net

Commit message

Port some miscellaneous code to Breezy

To post a comment you must log in.
Revision history for this message
Ioana Lasc (ilasc) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/registry/browser/product.py b/lib/lp/registry/browser/product.py
2index ad188ec..a424367 100644
3--- a/lib/lp/registry/browser/product.py
4+++ b/lib/lp/registry/browser/product.py
5@@ -44,8 +44,8 @@ __all__ = [
6 from operator import attrgetter
7 from urlparse import urlunsplit
8
9-from bzrlib import urlutils
10-from bzrlib.revision import NULL_REVISION
11+from breezy import urlutils
12+from breezy.revision import NULL_REVISION
13 from lazr.delegates import delegate_to
14 from lazr.restful.interface import (
15 copy_field,
16diff --git a/lib/lp/registry/model/distributionsourcepackage.py b/lib/lp/registry/model/distributionsourcepackage.py
17index d41d621..2dd3121 100644
18--- a/lib/lp/registry/model/distributionsourcepackage.py
19+++ b/lib/lp/registry/model/distributionsourcepackage.py
20@@ -17,7 +17,7 @@ from operator import (
21 )
22 from threading import local
23
24-from bzrlib.lru_cache import LRUCache
25+from breezy.lru_cache import LRUCache
26 from sqlobject.sqlbuilder import SQLConstant
27 from storm.expr import (
28 And,
29diff --git a/lib/lp/scripts/utilities/importpedant.py b/lib/lp/scripts/utilities/importpedant.py
30index 7a56898..7d7b268 100644
31--- a/lib/lp/scripts/utilities/importpedant.py
32+++ b/lib/lp/scripts/utilities/importpedant.py
33@@ -27,7 +27,6 @@ def text_lines_to_set(text):
34 # __all__. The following dict maps from such modules to a list of attributes
35 # that are allowed to be imported, whether or not they are in __all__.
36 valid_imports_not_in_all = {
37- 'bzrlib.lsprof': set(['BzrProfiler']),
38 'cookielib': set(['domain_match']),
39 # Exported in Python 3, but missing and so not exported in Python 2.
40 'json.decoder': set(['JSONDecodeError']),
41diff --git a/lib/lp/services/profile/profile.py b/lib/lp/services/profile/profile.py
42index 0c7a077..c44778a 100644
43--- a/lib/lp/services/profile/profile.py
44+++ b/lib/lp/services/profile/profile.py
45@@ -22,7 +22,7 @@ import StringIO
46 import sys
47 import threading
48
49-from bzrlib import lsprof
50+from breezy import lsprof
51 import oops_datedir_repo.serializer_rfc822
52 from zope.component import (
53 adapter,
54@@ -100,7 +100,7 @@ class Profiler:
55 This unhooks from threading and cleans up the profiler, returning
56 the gathered Stats object.
57
58- :return: A bzrlib.lsprof.Stats object.
59+ :return: A breezy.lsprof.Stats object.
60 """
61 try:
62 self.disable()
63diff --git a/lib/lp/services/testing/parallel.py b/lib/lp/services/testing/parallel.py
64index 23436de..26d9e09 100644
65--- a/lib/lp/services/testing/parallel.py
66+++ b/lib/lp/services/testing/parallel.py
67@@ -11,7 +11,7 @@ import subprocess
68 import sys
69 import tempfile
70
71-from bzrlib.osutils import local_concurrency
72+from breezy.osutils import local_concurrency
73 from subunit import ProtocolTestCase
74 from subunit.run import SubunitTestRunner
75 from testtools import (
76diff --git a/lib/lp/snappy/model/snap.py b/lib/lp/snappy/model/snap.py
77index 18eee6e..96aecd2 100644
78--- a/lib/lp/snappy/model/snap.py
79+++ b/lib/lp/snappy/model/snap.py
80@@ -17,8 +17,7 @@ from datetime import (
81 from operator import attrgetter
82 from urlparse import urlsplit
83
84-from bzrlib import urlutils
85-from bzrlib.errors import InvalidURLJoin
86+from breezy import urlutils
87 from lazr.lifecycle.event import ObjectCreatedEvent
88 from pymacaroons import Macaroon
89 import pytz
90@@ -1365,7 +1364,7 @@ class SnapSet:
91 raise MissingSnapcraftYaml(context.unique_name)
92 except GitRepositoryBlobUnsupportedRemote as e:
93 raise CannotFetchSnapcraftYaml(str(e), unsupported_remote=True)
94- except InvalidURLJoin as e:
95+ except urlutils.InvalidURLJoin as e:
96 raise CannotFetchSnapcraftYaml(str(e))
97 except (BranchHostingFault, GitRepositoryScanFault) as e:
98 msg = "Failed to get snap manifest from %s"
99diff --git a/lib/lp/testing/pgsql.py b/lib/lp/testing/pgsql.py
100index 70b4965..5ef18ba 100644
101--- a/lib/lp/testing/pgsql.py
102+++ b/lib/lp/testing/pgsql.py
103@@ -13,8 +13,8 @@ import random
104 import sys
105 import time
106
107-from bzrlib.errors import LockContention
108-from bzrlib.lock import WriteLock
109+from breezy.errors import LockContention
110+from breezy.lock import WriteLock
111 import psycopg2
112
113 from lp.services.config import config
114diff --git a/lib/lp/testing/tests/test_pages.py b/lib/lp/testing/tests/test_pages.py
115index 68d8259..738ee6d 100644
116--- a/lib/lp/testing/tests/test_pages.py
117+++ b/lib/lp/testing/tests/test_pages.py
118@@ -10,7 +10,7 @@ import shutil
119 import tempfile
120 import unittest
121
122-from bzrlib.tests import iter_suite_tests
123+from breezy.tests import iter_suite_tests
124
125 from lp.testing.layers import PageTestLayer
126 from lp.testing.pages import PageTestSuite
127diff --git a/utilities/get-branch-info b/utilities/get-branch-info
128index 128ca9a..5143087 100755
129--- a/utilities/get-branch-info
130+++ b/utilities/get-branch-info
131@@ -12,7 +12,7 @@ import _pythonpath
132
133 import sys
134
135-from bzrlib.urlutils import join
136+from breezy.urlutils import join
137 from zope.component import getUtility
138
139 from lp.code.enums import BranchType

Subscribers

People subscribed via source and target branches

to status/vote changes: